Ctrulib upgrade #24
Open
Ctrulib upgrade #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update can't shutdown properly, for reasons unknown. It has been tested to at least be able to read and write saves.
Removed calls to *Init/Exit functions that are already called by __appInit and __appExit in ctrulib.
|
Fixes #22 |
|
It seems the crashing problem was already a thing (issue #19), so it doesn't seem like this work causes a regression. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests upgrades svdt to compile with ctrulib-1+. I tested the anti-anit hacking functionality with Smash4, and it seems to be working. The only thing that doesn't work reliably is returning to the HBL after pressing Start-- the program sometimes hangs, sometimes doesn't (sounds like a possible memory management problem somewhere).
Also did some changes to make some formatting/line-endings (more) consistent.